feat: Allow to override metrics' host project#991
Open
juli4n wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
Open
feat: Allow to override metrics' host project#991juli4n wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
juli4n wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
Conversation
This change allows to specify the host project of a metric in the metric spec, so that the adapter can fetch metrics from a different project than the one where the adapter is running.
This is useful in scenarios where metrics are stored in a central project, but the HPA is running in a different project.
The host project can be specified by adding the `resource.labels.metrics_host_project_id` label to the metric selector in the HPA definition.
For external metrics, the legacy `resource.labels.project_id` label is also supported for backward compatibility.
How to use:
To fetch a metric from a different project, add the `resource.labels.metrics_host_project_id` label to the metric selector in the HPA definition.
Example for a custom metric:
```yaml
apiVersion: autoscaling/v2beta2
kind: HorizontalPodAutoscaler
metadata:
name: custom-metric-hpa
spec:
scaleTargetRef:
apiVersion: apps/v1
kind: Deployment
name: my-app
minReplicas: 1
maxReplicas: 10
metrics:
- type: Pods
pods:
metric:
name: my-metric
selector:
matchLabels:
"resource.labels.metrics_host_project_id": "my-metrics-project"
target:
type: AverageValue
averageValue: 10
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows to specify the host project of a metric in the metric spec, so that the adapter can fetch metrics from a different project than the one where the adapter is running.
This is useful in scenarios where metrics are stored in a central project, but the HPA is running in a different project.
The host project can be specified by adding the
resource.labels.metrics_host_project_idlabel to the metric selector in the HPA definition.For external metrics, the legacy
resource.labels.project_idlabel is also supported for backward compatibility.How to use:
To fetch a metric from a different project, add the
resource.labels.metrics_host_project_idlabel to the metric selector in the HPA definition.Example for a custom metric:
Fixes #979